lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] soc: mediatek: mutex: add suffix 0 to DDP_COMPONENT_DITHER for mt8395
    From
    Il 23/06/22 02:33, Jason-JH Lin ha scritto:
    > Hi Angelo,
    >
    > Yes, I missed that!
    > So just forget about this patch and use yours.
    >
    > Thanks for your help :)
    >

    No worries, it happens...
    Btw, you're welcome.

    Cheers!

    > Regard,
    > Jason-JH.Lin
    >
    > On Wed, 2022-06-22 at 15:31 +0200, AngeloGioacchino Del Regno wrote:
    >> Il 22/06/22 15:19, Jason-JH.Lin ha scritto:
    >>> Add suffix 0 to DDP_COMPONENT_DITHER for mt8395.
    >>>
    >>> Fixes: 141311b856d8 ("soc: mediatek: mutex: add MT8365 support")
    >>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
    >>
    >>
    >> Hello Jason-JH,
    >>
    >> you must've missed my commit, sent two days ago, which is doing the
    >> same:
    >>
    >>
    > https://lore.kernel.org/lkml/20220620102454.131417-1-angelogioacchino.delregno@collabora.com/T/#u
    >>
    >> Anyway, I have avoided to rename the definition, as from what I
    >> understand
    >> MT8365 has only one dither mod and that's called "DITHER", not
    >> "DITHER0"...
    >> ...but I've added the suffix to the array assignment, as that's what
    >> we have
    >> in the enumeration.
    >>
    >> I think that #define MT8365_MUTEX_MOD_DISP_DITHER should be kept as-
    >> is.
    >>
    >> Also... this commit is not fixing anything, as it was already working
    >> before,
    >> so the Fixes tag shouldn't be present.
    >>
    >> Regards,
    >> Angelo
    >>

    \
     
     \ /
      Last update: 2022-06-23 10:14    [W:4.520 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site