lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 3/3] scsi: ufs: ufshcd: constify pointed data
From
On 22/06/2022 18:13, Bart Van Assche wrote:
> On 6/13/22 03:06, Krzysztof Kozlowski wrote:
>> Constify arrays and pointers to data which is not modified for code
> ^^
>> safety.
>
> is -> are?
>
>> @@ -7848,7 +7850,7 @@ static int ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba)
>> u32 granularity, peer_granularity;
>> u32 pa_tactivate, peer_pa_tactivate;
>> u32 pa_tactivate_us, peer_pa_tactivate_us;
>> - u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};
>> + const u8 gran_to_us_table[] = {1, 4, 8, 16, 32, 100};
>
> Can this array be declared static? Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Could be, it's a kind of optimization, so a bit different problem. I'll
send v4 with language fix, static and your review.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-23 09:17    [W:0.053 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site