lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 218/234] ext4: make variable "count" signed
    Date
    From: Ding Xiang <dingxiang@cmss.chinamobile.com>

    commit bc75a6eb856cb1507fa907bf6c1eda91b3fef52f upstream.

    Since dx_make_map() may return -EFSCORRUPTED now, so change "count" to
    be a signed integer so we can correctly check for an error code returned
    by dx_make_map().

    Fixes: 46c116b920eb ("ext4: verify dir block before splitting it")
    Cc: stable@kernel.org
    Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
    Link: https://lore.kernel.org/r/20220530100047.537598-1-dingxiang@cmss.chinamobile.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/namei.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/ext4/namei.c
    +++ b/fs/ext4/namei.c
    @@ -1743,7 +1743,8 @@ static struct ext4_dir_entry_2 *do_split
    struct dx_hash_info *hinfo)
    {
    unsigned blocksize = dir->i_sb->s_blocksize;
    - unsigned count, continued;
    + unsigned continued;
    + int count;
    struct buffer_head *bh2;
    ext4_lblk_t newblock;
    u32 hash2;

    \
     
     \ /
      Last update: 2022-06-23 20:24    [W:4.362 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site