lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 200/234] i40e: Fix adding ADQ filter to TC0
    Date
    From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>

    [ Upstream commit c3238d36c3a2be0a29a9d848d6c51e1b14be6692 ]

    Procedure of configure tc flower filters erroneously allows to create
    filters on TC0 where unfiltered packets are also directed by default.
    Issue was caused by insufficient checks of hw_tc parameter specifying
    the hardware traffic class to pass matching packets to.

    Fix checking hw_tc parameter which blocks creation of filters on TC0.

    Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
    Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
    Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
    Tested-by: Bharathi Sreenivas <bharathi.sreenivas@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
    index 21ea0cdea666..3615c6533cf4 100644
    --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
    +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
    @@ -7508,6 +7508,11 @@ static int i40e_configure_clsflower(struct i40e_vsi *vsi,
    return -EOPNOTSUPP;
    }

    + if (!tc) {
    + dev_err(&pf->pdev->dev, "Unable to add filter because of invalid destination");
    + return -EINVAL;
    + }
    +
    if (test_bit(__I40E_RESET_RECOVERY_PENDING, pf->state) ||
    test_bit(__I40E_RESET_INTR_RECEIVED, pf->state))
    return -EBUSY;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-23 20:20    [W:4.114 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site