lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 203/234] misc: atmel-ssc: Fix IRQ check in ssc_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 1c245358ce0b13669f6d1625f7a4e05c41f28980 ]

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
    Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220601123026.7119-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/misc/atmel-ssc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
    index f9caf233e2cc..48521861beb5 100644
    --- a/drivers/misc/atmel-ssc.c
    +++ b/drivers/misc/atmel-ssc.c
    @@ -235,9 +235,9 @@ static int ssc_probe(struct platform_device *pdev)
    clk_disable_unprepare(ssc->clk);

    ssc->irq = platform_get_irq(pdev, 0);
    - if (!ssc->irq) {
    + if (ssc->irq < 0) {
    dev_dbg(&pdev->dev, "could not get irq\n");
    - return -ENXIO;
    + return ssc->irq;
    }

    mutex_lock(&user_lock);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-23 20:18    [W:4.129 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site