Messages in this thread Patch in this message | | | From | Jianglei Nie <> | Subject | [PATCH] net: sfp: fix memory leak in sfp_probe() | Date | Thu, 23 Jun 2022 15:09:14 +0800 |
| |
sfp_probe() allocates a memory chunk from sfp with sfp_alloc(), when devm_add_action() fails, sfp is not freed, which leads to a memory leak.
We should free the sfp with sfp_cleanup() when devm_add_action() fails.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com> --- drivers/net/phy/sfp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 9a5d5a10560f..366a89adabf5 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -2517,8 +2517,10 @@ static int sfp_probe(struct platform_device *pdev) platform_set_drvdata(pdev, sfp); err = devm_add_action(sfp->dev, sfp_cleanup, sfp); - if (err < 0) + if (err < 0) { + sfp_cleanup(sfp); return err; + } sff = sfp->type = &sfp_data; -- 2.25.1
| |