lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 040/234] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
    Date
    From: Richard Henderson <richard.henderson@linaro.org>

    commit 904caa6413c87aacbf7d0682da617c39ca18cf1a upstream.

    We must not use the pointer output without validating the
    success of the random read.

    Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Richard Henderson <rth@twiddle.net>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Link: https://lore.kernel.org/r/20200110145422.49141-7-broonie@kernel.org
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/linux/random.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/include/linux/random.h
    +++ b/include/linux/random.h
    @@ -118,19 +118,19 @@ unsigned long randomize_page(unsigned lo
    #ifdef CONFIG_ARCH_RANDOM
    # include <asm/archrandom.h>
    #else
    -static inline bool arch_get_random_long(unsigned long *v)
    +static inline bool __must_check arch_get_random_long(unsigned long *v)
    {
    return false;
    }
    -static inline bool arch_get_random_int(unsigned int *v)
    +static inline bool __must_check arch_get_random_int(unsigned int *v)
    {
    return false;
    }
    -static inline bool arch_get_random_seed_long(unsigned long *v)
    +static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
    {
    return false;
    }
    -static inline bool arch_get_random_seed_int(unsigned int *v)
    +static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
    {
    return false;
    }

    \
     
     \ /
      Last update: 2022-06-23 20:01    [W:4.099 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site