lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] arm64: dts: qcom: add SC8280XP platform
On Thu, Jun 23, 2022 at 10:52:50AM +0530, Vinod Koul wrote:
> On 07-06-22, 14:41, Bjorn Andersson wrote:
> > + aggre1_noc: interconncet-aggre1-noc {

> s/interconncet/interconnect

Note that you're reviewing v1 and that this has since been fixed.

> Hmmm I thought it was required that node name should be interconnect@x

> > + usb_0_hsphy: phy@88e5000 {
> > + compatible = "qcom,sc8280xp-usb-hs-phy",
> > + "qcom,usb-snps-hs-5nm-phy";
> > + reg = <0 0x088e5000 0 0x400>;
>
> this doesn't match with node address above (I think W=1 would warn you
> of such mismatches, useful to run on new dts

This unit address is actually correct, but there were some other
mismatches that were also fixed in v2.

Johan

\
 
 \ /
  Last update: 2022-06-23 08:43    [W:0.170 / U:5.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site