lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 003/237] random: always fill buffer in get_random_bytes_wait
    Date
    From: "Jason A. Donenfeld" <Jason@zx2c4.com>

    commit 25e3fca492035a2e1d4ac6e3b1edd9c1acd48897 upstream.

    In the unfortunate event that a developer fails to check the return
    value of get_random_bytes_wait, or simply wants to make a "best effort"
    attempt, for whatever that's worth, it's much better to still fill the
    buffer with _something_ rather than catastrophically failing in the case
    of an interruption. This is both a defense in depth measure against
    inevitable programming bugs, as well as a means of making the API a bit
    more useful.

    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/linux/random.h | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/include/linux/random.h
    +++ b/include/linux/random.h
    @@ -85,10 +85,8 @@ static inline unsigned long get_random_c
    static inline int get_random_bytes_wait(void *buf, int nbytes)
    {
    int ret = wait_for_random_bytes();
    - if (unlikely(ret))
    - return ret;
    get_random_bytes(buf, nbytes);
    - return 0;
    + return ret;
    }

    #define declare_get_random_var_wait(var) \

    \
     
     \ /
      Last update: 2022-06-23 19:24    [W:4.153 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site