Messages in this thread | | | Date | Wed, 22 Jun 2022 15:48:12 +0200 | From | Alexander Gordeev <> | Subject | Re: [PATCH 2/3] s390/purgatory: hard-code obj-y in Makefile |
| |
On Tue, Jun 14, 2022 at 02:09:01AM +0900, Masahiro Yamada wrote: > The purgatory/ directory is entirely guarded in arch/s390/Kbuild. > CONFIG_ARCH_HAS_KEXEC_PURGATORY is bool type. > > $(CONFIG_ARCH_HAS_KEXEC_PURGATORY) is always 'y' when Kbuild visits > this Makefile for building. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/s390/purgatory/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/purgatory/Makefile b/arch/s390/purgatory/Makefile > index 360ada80d20c..3e2c17ba04de 100644 > --- a/arch/s390/purgatory/Makefile > +++ b/arch/s390/purgatory/Makefile > @@ -51,4 +51,4 @@ $(obj)/purgatory.ro: $(obj)/purgatory $(obj)/purgatory.chk FORCE > $(obj)/kexec-purgatory.o: $(obj)/kexec-purgatory.S $(obj)/purgatory.ro FORCE > $(call if_changed_rule,as_o_S) > > -obj-$(CONFIG_ARCH_HAS_KEXEC_PURGATORY) += kexec-purgatory.o > +obj-y += kexec-purgatory.o
Applied, thanks!
BTW, it looks like x86 and riscv also need similar change.
In addition, x86 use of CONFIG_ARCH_HAS_KEXEC_PURGATORY vs CONFIG_KEXEC_FILE is not consistent with other architectures (may be even incorrect?).
> -- > 2.32.0 >
| |