Messages in this thread | | | Date | Wed, 22 Jun 2022 15:44:49 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v2 5/6] arm64: dts: qcom: add SA8540P and ADP |
| |
On Wed, Jun 22, 2022 at 02:37:02PM +0200, Konrad Dybcio wrote: > On 22.06.2022 06:12, Bjorn Andersson wrote:
> > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts > > @@ -0,0 +1,427 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2022, Linaro Limited > > + */ > > + > > +/dts-v1/; > > + > > +#include <dt-bindings/gpio/gpio.h> > Can be moved to SoC dtsi.
No, the SoC dtsi does not use any defines from that header file.
> > +#include <dt-bindings/input/gpio-keys.h> > > +#include <dt-bindings/input/input.h> > > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > +#include <dt-bindings/spmi/spmi.h>
> > + > > +/* PINCTRL */ > Seems redundant.
See my previous answer to this.
Johan
| |