lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()
Date
Am Mittwoch, 22. Juni 2022, 11:00:11 CEST schrieb Krzysztof Kozlowski:
> On 16/06/2022 04:17, Liang He wrote:
> > In rockchip_suspend_init(), of_find_matching_node_and_match() will
> > return a node pointer with refcount incremented. We should use
> > of_node_put() in fail path or when it is not used anymore.
> >
> > Signed-off-by: Liang He <windhl@126.com>
> > ---
> > changelog:
> >
> > v2: (1) use real name for Sob (2) use goto-label patch style
> > v1: add of_node_put() for each return
> >
>
> Before applying the patch please check it carefully. Previous evidence
> [1][2] suggests that not it was not even compiled.

thanks noticing possible issues and for the heads up :-) .

I re-examined the patch and at least in this case the of_node_put addition
looks correct - the original code was missing this and not putting the node
it got in the error case. And the change also compiles :-) .

Heiko

> [1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
>
> [2]
> https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/
>
>
> Best regards,
> Krzysztof
>




\
 
 \ /
  Last update: 2022-06-22 15:12    [W:0.067 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site