lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 21/22] x86/virt/tdx: Support kexec()
    Date
    To support kexec(), if the TDX module is ever initialized, the kernel
    needs to flush all dirty cachelines associated with any TDX private
    KeyID, otherwise they may slightly corrupt the new kernel.

    Following SME support, use wbinvd() to flush cache in stop_this_cpu().
    Theoretically, cache flush is only needed when the TDX module has been
    initialized. However initializing the TDX module is done on demand at
    runtime, and it takes a mutex to read the module status. Just check
    whether TDX is enabled by BIOS instead to flush cache.

    The current TDX module architecture doesn't play nicely with kexec().
    The TDX module can only be initialized once during its lifetime, and
    there is no SEAMCALL to reset the module to give a new clean slate to
    the new kernel. Therefore, ideally, if the module is ever initialized,
    it's better to shut down the module. The new kernel won't be able to
    use TDX anyway (as it needs to go through the TDX module initialization
    process which will fail immediately at the first step).

    However, there's no guarantee CPU is in VMX operation during kexec().
    This means it's impractical to shut down the module. Just do nothing
    but leave the module open.

    Signed-off-by: Kai Huang <kai.huang@intel.com>
    ---
    arch/x86/kernel/process.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
    index dbaf12c43fe1..ff5449c23522 100644
    --- a/arch/x86/kernel/process.c
    +++ b/arch/x86/kernel/process.c
    @@ -769,8 +769,15 @@ void __noreturn stop_this_cpu(void *dummy)
    *
    * Test the CPUID bit directly because the machine might've cleared
    * X86_FEATURE_SME due to cmdline options.
    + *
    + * Similar to SME, if the TDX module is ever initialized, the
    + * cachelines associated with any TDX private KeyID must be
    + * flushed before transiting to the new kernel. The TDX module
    + * is initialized on demand, and it takes the mutex to read it's
    + * status. Just check whether TDX is enabled by BIOS instead to
    + * flush cache.
    */
    - if (cpuid_eax(0x8000001f) & BIT(0))
    + if (cpuid_eax(0x8000001f) & BIT(0) || platform_tdx_enabled())
    native_wbinvd();
    for (;;) {
    /*
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-06-22 13:20    [W:4.045 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site