lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 04/22] x86/virt/tdx: Prevent ACPI CPU hotplug and ACPI memory hotplug
    Date
    Intel Trust Domain Extensions (TDX) protects guest VMs from malicious
    host and certain physical attacks. To guarantee the security, TDX
    imposes additional requirements on both CPU and memory.

    TDX doesn't work with ACPI CPU hotplug. During platform boot, MCHECK
    verifies all logical CPUs on all packages are TDX compatible. Any
    hot-added CPU at runtime is not verified thus cannot support TDX. And
    TDX requires all boot-time verified CPUs being present during machine's
    runtime, so TDX doesn't support ACPI CPU hot-removal either.

    TDX doesn't work with ACPI memory hotplug either. TDX also provides
    increased levels of memory confidentiality and integrity. During
    platform boot, MCHECK also verifies all TDX-capable memory regions are
    physically present and meet TDX's security requirements. Any hot-added
    memory is not verified thus cannot work with TDX. TDX also assumes all
    TDX-capable memory regions are present during machine's runtime thus it
    doesn't support ACPI memory removal either.

    Select ARCH_HAS_CC_PLATFORM when CONFIG_INTEL_TDX_HOST is on. Set CC
    vendor to CC_VENDOR_INTEL if TDX is enabled by BIOS, and report ACPI CPU
    hotplug and ACPI memory hotplug attributes as disabled to prevent them.

    Note TDX does allow CPU to go offline and then to be brought up again, so
    software CPU hotplug attribute is not reported.

    Signed-off-by: Kai Huang <kai.huang@intel.com>
    ---
    arch/x86/Kconfig | 1 +
    arch/x86/coco/core.c | 32 +++++++++++++++++++++++++++++++-
    arch/x86/virt/vmx/tdx/tdx.c | 4 ++++
    3 files changed, 36 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
    index 23f21aa3a5c4..efa830853e98 100644
    --- a/arch/x86/Kconfig
    +++ b/arch/x86/Kconfig
    @@ -1973,6 +1973,7 @@ config INTEL_TDX_HOST
    depends on CPU_SUP_INTEL
    depends on X86_64
    depends on KVM_INTEL
    + select ARCH_HAS_CC_PLATFORM
    help
    Intel Trust Domain Extensions (TDX) protects guest VMs from malicious
    host and certain physical attacks. This option enables necessary TDX
    diff --git a/arch/x86/coco/core.c b/arch/x86/coco/core.c
    index 1bde1af75296..e4c9e34c452f 100644
    --- a/arch/x86/coco/core.c
    +++ b/arch/x86/coco/core.c
    @@ -12,11 +12,14 @@

    #include <asm/coco.h>
    #include <asm/processor.h>
    +#include <asm/cpufeature.h>
    +#include <asm/tdx.h>

    static enum cc_vendor vendor __ro_after_init;
    static u64 cc_mask __ro_after_init;

    -static bool intel_cc_platform_has(enum cc_attr attr)
    +#ifdef CONFIG_INTEL_TDX_GUEST
    +static bool intel_tdx_guest_has(enum cc_attr attr)
    {
    switch (attr) {
    case CC_ATTR_GUEST_UNROLL_STRING_IO:
    @@ -28,6 +31,33 @@ static bool intel_cc_platform_has(enum cc_attr attr)
    return false;
    }
    }
    +#endif
    +
    +#ifdef CONFIG_INTEL_TDX_HOST
    +static bool intel_tdx_host_has(enum cc_attr attr)
    +{
    + switch (attr) {
    + case CC_ATTR_ACPI_CPU_HOTPLUG_DISABLED:
    + case CC_ATTR_ACPI_MEMORY_HOTPLUG_DISABLED:
    + return true;
    + default:
    + return false;
    + }
    +}
    +#endif
    +
    +static bool intel_cc_platform_has(enum cc_attr attr)
    +{
    +#ifdef CONFIG_INTEL_TDX_GUEST
    + if (boot_cpu_has(X86_FEATURE_TDX_GUEST))
    + return intel_tdx_guest_has(attr);
    +#endif
    +#ifdef CONFIG_INTEL_TDX_HOST
    + if (platform_tdx_enabled())
    + return intel_tdx_host_has(attr);
    +#endif
    + return false;
    +}

    /*
    * SME and SEV are very similar but they are not the same, so there are
    diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
    index 8275007702e6..eb3294bf1b0a 100644
    --- a/arch/x86/virt/vmx/tdx/tdx.c
    +++ b/arch/x86/virt/vmx/tdx/tdx.c
    @@ -15,6 +15,7 @@
    #include <asm/msr-index.h>
    #include <asm/msr.h>
    #include <asm/tdx.h>
    +#include <asm/coco.h>
    #include "tdx.h"

    static u32 tdx_keyid_start __ro_after_init;
    @@ -92,6 +93,9 @@ static int __init tdx_early_detect(void)
    if (ret)
    return ret;

    + /* Set TDX enabled platform as confidential computing platform */
    + cc_set_vendor(CC_VENDOR_INTEL);
    +
    pr_info("TDX enabled by BIOS.\n");
    return 0;
    }
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-06-22 13:16    [W:4.046 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site