lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ARC:mm:Fix syntax errors in comments
Date
On 6/22/22 11:16, Julia Lawall wrote:
>
>
> On Wed, 22 Jun 2022, Shahab Vahedi wrote:
>
>> On 6/22/22 10:30, Bagas Sanjaya wrote:
>>
>>> I think that this kind of cleanup patches (typofixes) are best done
>>> as part of **actual** work on the code in question (for example
>>> refactoring or fixing build errors).
>>
>> Amen!
>
> So code that is fine will have typos forever? Fixing typos in comments
> doesn't break git blame for the following code. And typos in comments
> give a bad impression about the state of the code in general.

Of course not! Documentation is as important as the code, if not even more.
However, fixing typos to increase your commit counts to a reputable project
is not fine either. For instance, many of these proposed fixes are targeting
one single typo at a time. Couldn't they just be sent altogether!?!

--
Shahab
\
 
 \ /
  Last update: 2022-06-22 11:27    [W:0.522 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site