Messages in this thread | | | Date | Wed, 22 Jun 2022 11:06:51 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v2 4/6] arm64: dts: qcom: sc8280xp: Add reference device |
| |
On Tue, Jun 21, 2022 at 09:12:22PM -0700, Bjorn Andersson wrote: > Add basic support for the SC8280XP reference device, which allows it to > boot to a shell (using EFIFB) with functional storage (UFS), USB, > keyboard, touchpad, touchscreen, backlight and remoteprocs. > > The PMICs are, per socinfo, reused from other platforms. But given that > the address of the PMICs doesn't match other cases and that it's > desirable to label things according to the schematics a new dtsi file is > created to represent the reference combination of PMICs. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Changes since v1: > - Reordered "status" last > - Fixed invalid PMIC gpio 0 > - Replaced "hid" name with touchscreen, touchpad and keyboard
You also added the HID vdd-supply properties from the X13s devicetree.
I assume the CRD also uses vreg_misc_3p3 for these (always-on for now anyway).
> - Added &xo_board_clk frequency
> + vreg_misc_3p3: misc-3p3-regulator { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_MISC_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&pmc8280_1_gpios 1 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&misc_3p3_reg_en>; > + > + regulator-boot-on; > + regulator-always-on; > + };
> +&qup0_i2c4 { > + clock-frequency = <400000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&qup0_i2c4_default>, <&ts0_default>; > + > + status = "okay"; > + > + touchscreen@10 { > + compatible = "hid-over-i2c"; > + reg = <0x10>; > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 175 IRQ_TYPE_LEVEL_LOW>; > + vdd-supply = <&vreg_misc_3p3>; > + }; > +};
> +&qup2_i2c5 { > + clock-frequency = <400000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&qup2_i2c5_default>, <&kybd_default>, <&tpad_default>; > + > + status = "okay"; > + > + touchpad@15 { > + compatible = "hid-over-i2c"; > + reg = <0x15>; > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 182 IRQ_TYPE_LEVEL_LOW>; > + vdd-supply = <&vreg_misc_3p3>; > + }; > + > + keyboard@68 { > + compatible = "hid-over-i2c"; > + reg = <0x68>; > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; > + vdd-supply = <&vreg_misc_3p3>; > + }; > +};
[...]
> +&usb_1_qmpphy { > + vdda-phy-supply = <&vreg_l4b>; > + vdda-pll-supply = <&vreg_l3b>; > + > + status = "okay"; > +}; > + > +/* PINCTRL - additions to nodes defined in sc8280xp.dtsi */ > + > +&pmc8280_1_gpios { > + edp_bl_en: edp-bl-en-state { > + pins = "gpio8"; > + function = "normal"; > + }; > + > + edp_bl_reg_en: edp-bl-reg-en-state { > + pins = "gpio9"; > + function = "normal"; > + }; > + > + misc_3p3_reg_en: misc-3p3-reg-en-state { > + pins = "gpio1"; > + function = "normal"; > + }; > +}; > + > +&pmc8280c_gpios { > + edp_bl_pwm: edp-bl-pwm-state { > + pins = "gpio8"; > + function = "func1"; > + }; > +}; > + > +&xo_board_clk { > + clock-frequency = <38400000>; > +};
Nit: This one should go after &usb_1_qmpphy above if we want to keep the pinctrl nodes last.
> + > +&tlmm {
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
| |