lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 07/14] ALSA: hda: cs35l41: Support multiple load paths for firmware
    From
    On 6/22/2022 9:46 AM, Vitaly Rodionov wrote:
    > From: Stefan Binding <sbinding@opensource.cirrus.com>
    >
    > To be able to support different firmwares and tuning
    > for different models, the driver needs to be able to
    > load a different firmware and coefficient file based
    > on its Subsystem ID.
    >
    > The driver attempts to load the firmware in the
    > following order:
    >
    > /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>-dev<#>.wmfw
    > /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>-<ssid>.wmfw
    > /lib/firmware/cirrus/cs35l41-dsp1-<fw-type>.wmfw
    >
    > Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
    > Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
    > ---

    ...

    CS35L41_FIRMWARE_ROOT, NULL, NULL, "wmfw");
    > + if (!ret) {
    > + /* fallback try cirrus/part-dspN-fwtype.bin */
    > cs35l41_request_firmware_file(cs35l41, coeff_firmware, coeff_filename,
    > - CS35L41_FIRMWARE_ROOT, "bin");
    > + CS35L41_FIRMWARE_ROOT, NULL, NULL, "bin");
    > return 0;
    > }
    >
    > @@ -143,7 +183,6 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41,
    > return ret;
    > }
    >
    > -

    You add unnecessary line in patch 4 and remove in this one?

    > static int cs35l41_init_dsp(struct cs35l41_hda *cs35l41)
    > {
    > const struct firmware *coeff_firmware = NULL;

    \
     
     \ /
      Last update: 2022-06-22 10:43    [W:4.175 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site