Messages in this thread | | | Date | Wed, 22 Jun 2022 09:29:49 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe() |
| |
On Wed, 22 Jun 2022 09:15:56 +0100, "Liang He" <windhl@126.com> wrote: > > > > At 2022-06-22 16:03:26, "Marc Zyngier" <maz@kernel.org> wrote: > >+ Miaoqian Lin > > > >On Wed, 22 Jun 2022 07:21:38 +0100, > >Liang He <windhl@126.com> wrote: > >> > >> We need to add missing of_node_get() for of_find_matching_node() to > >> keep refcount balance. > >> > >> Note: of_find_matching_node() will decrease the refcount of its first > >> arg. > >> > >> Signed-off-by: Liang He <windhl@126.com> > > > >[...] > > > >Please send these refcount fixes as a series for all the irqchip > >drivers, not one every other day. > > > > Sorry, I will group similar bugs in future. > > > >And please synchronise with Miaoqian Lin, as you are obviously both > >chasing the same bugs. > > > >Thanks, > > > > M. > > Yes, before I send any new bug, I will confirm that this bug has not > been reported in lore.kernel.org.
This is not what I meant. I am asking you to actively coordinate with Miaoqian, working with them as a team instead of you both sending competing series. I would like to see one series with patches from you both.
> By the way, this is a bug missing |GET|, not |PUT|, which is > different with Miaoqian's and my patches before.
Well, yet another reason for you both to work together, as you are complementing each other.
Thanks,
M.
-- Without deviation from the norm, progress is not possible.
| |