Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 22 Jun 2022 09:19:29 +0200 | Subject | Re: [PATCH] m68k:mac:Fix syntax errors in comments |
| |
Hi Jilin,
On Wed, Jun 22, 2022 at 8:10 AM Jilin Yuan <yuanjilin@cdjrlc.com> wrote: > Delete the redundant word 'in'. > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
Thanks for your patch!
> --- a/arch/m68k/mac/misc.c > +++ b/arch/m68k/mac/misc.c > @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data) > > reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData); > > - /* The bits of the byte go in in MSB order */ > + /* The bits of the byte go in MSB order */
The original is actually correct: "to go in", "in MSB order".
> > for (i = 0 ; i < 8 ; i++) { > bit = data & 0x80? 1 : 0;
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |