lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] rcu: Add a warnings in sync_sched_exp_online_cleanup()
Date

Add Cc

Currently, the sync_sched_exp_online_cleanup() is invoked in
cpuhp per-cpu kthreads when CPU is going online, so the CPU id
obtained by get_cpu() should always be equal to the CPU id of
the passed parameter, that is to say, the smp_call_function_single()
never be invoked, if be invoked, there may be problem with cpu-hotplug,
this commit add WARN_ON_ONCE() to remind everyone.

Signed-off-by: Zqiang <qiang1.zhang@intel.com>
---
kernel/rcu/tree_exp.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
index be667583a554..ae8dcfd4486c 100644
--- a/kernel/rcu/tree_exp.h
+++ b/kernel/rcu/tree_exp.h
@@ -865,6 +865,8 @@ static void sync_sched_exp_online_cleanup(int cpu)
put_cpu();
return;
}
+
+ WARN_ON_ONCE(my_cpu != cpu);
/* Quiescent state needed on some other CPU, send IPI. */
ret = smp_call_function_single(cpu, rcu_exp_handler, NULL, 0);
put_cpu();
--
2.25.1
\
 
 \ /
  Last update: 2022-06-23 01:44    [W:0.062 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site