lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V11 3/8] PCI: Create PCI library functions in support of DOE mailboxes.
On Mon, Jun 20, 2022 at 11:23:28AM +0100, Jonathan Cameron wrote:
> On Fri, 17 Jun 2022 15:56:38 -0700
> Dan Williams <dan.j.williams@intel.com> wrote:
>

[snip]

> > > +static int pci_doe_enable_irq(struct pci_doe_mb *doe_mb, unsigned int irq)
> > > +{
> > > + struct pci_dev *pdev = doe_mb->pdev;
> > > + int offset = doe_mb->cap_offset;
> > > + int rc;
> > > +
> > > + /*
> > > + * Enabling bus mastering is required for MSI/MSIx. It is safe to call
> > > + * this multiple times and thus is called here to ensure that mastering
> > > + * is enabled even if the driver has done so.
> > > + */
> >
> > It is required for MSI/MSIx to work, yes, but if the caller that created
> > the doe object has not set it yet that's its prerogative.
>
> We went around this in one of the earlier threads, and I think consensus
> was that it made sense to have this in core code.

Yes we did. This is where Bjorn asked for this to be done I thought.

I verified that pci_set_master() is fine to call more than one time. If the
caller asks for irq support I think it is fine to do this here to ensure that
support is enabled.

Ira

\
 
 \ /
  Last update: 2022-06-23 01:00    [W:0.125 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site