lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v9 5/5] arm64: dts: qcom: sc7180: Add kingoftown dts files
    Hi,

    On Mon, Jun 20, 2022 at 10:35 PM Joseph S. Barrera III
    <joebar@chromium.org> wrote:
    >
    > Kingoftown is a trogdor-based board. These dts files are unchanged copies
    > from the downstream Chrome OS 5.4 kernel.
    >
    > Signed-off-by: Joseph S. Barrera III <joebar@chromium.org>
    > ---
    >
    > Changes in v9:
    > - Simplify trackpad enabling (51d30402be75).
    >
    > Changes in v7:
    > - Simplify spi0/spi6 labeling (d277cab7afc7).
    > - Remove #include of <arm/cros-ec-keyboard.dtsi>.
    >
    > Changes in v6:
    > - Add #include of <arm/cros-ec-keyboard.dtsi> from v5.4.
    >
    > Changes in v4:
    > - Fix description (no downstream bits removed).
    > - Add missing version history.
    >
    > Changes in v2:
    > - First inclusion in series.
    >
    > arch/arm64/boot/dts/qcom/Makefile | 2 +
    > .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 44 ++++
    > .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 ++
    > .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 224 ++++++++++++++++++
    > 4 files changed, 287 insertions(+)
    > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
    > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts
    > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
    >
    > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
    > index dc26704dfe34..a9f2ad013179 100644
    > --- a/arch/arm64/boot/dts/qcom/Makefile
    > +++ b/arch/arm64/boot/dts/qcom/Makefile
    > @@ -60,6 +60,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb
    > +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r0.dtb
    > +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r1.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb
    > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
    > new file mode 100644
    > index 000000000000..85aec1be98fc
    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
    > @@ -0,0 +1,44 @@
    > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
    > +/*
    > + * Google Kingoftown board device tree source
    > + *
    > + * Copyright 2021 Google LLC.
    > + */
    > +
    > +/dts-v1/;
    > +
    > +#include "sc7180.dtsi"

    Just like for pazquel, the fact that you have "sc7180.dtsi" included
    here means that you didn't incorporate the "Simplify!" changes
    properly. Please try again.

    -Doug

    \
     
     \ /
      Last update: 2022-06-22 22:58    [W:5.421 / U:0.756 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site