Messages in this thread | | | From | Stephen Zhang <> | Date | Tue, 21 Jun 2022 15:04:20 +0800 | Subject | Re: [PATCH] xfs: return when delta equals 0 in xfs_mod_freecounter |
| |
Dave Chinner <david@fromorbit.com> 于2022年6月21日周二 12:35写道: > > On Tue, Jun 21, 2022 at 11:11:13AM +0800, Shida Zhang wrote: > > There are cases that xfs_mod_freecounter() will get called when delta > > equals 0 while it's unnecessary. > > AFAICT all of the call paths are guarded by checks to ensure the > delta is, in fact, not zero. i.e. if the delta is zero, we shouldn't > be calling xfs_mod_fdblocks() or xfs_mod_frextents() at all. > > Can you explain in more detail what code path leads to delta = 0 > here? > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com
Yeah. I will give it in another v2 version patch.
Cheers,
Stephen.
| |