lkml.org 
[lkml]   [2022]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush
Date
Paolo Bonzini <pbonzini@redhat.com> writes:

> On 6/13/22 15:39, Vitaly Kuznetsov wrote:
>> - tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu);
>> + tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu, is_guest_mode(vcpu));
>>
>
> Any reason to add this parameter?

Yes) Other users (all from kvm_hv_flush_tlb()) set this parameter based
on whether the calling vCPU (*not* the destination vCPU, which is the
first parameter) is in guest mode or not.

> It is always set to is_guest_mode(vcpu) and, even if it wasn't, I
> would add the parameter directly in patch 11.

I can move to Patch11 if necessary.

--
Vitaly

\
 
 \ /
  Last update: 2022-06-21 15:29    [W:0.105 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site