lkml.org 
[lkml]   [2022]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] iommu: Clean up release_device checks
From
On 2022/6/21 23:14, Robin Murphy wrote:
> Since .release_device is now called through per-device ops, any call
> which gets as far as a driver definitely*is* for that driver, for a
> device which has successfully passed .probe_device, so all the checks to
> that effect are now redundant and can be removed. In the same vein we
> can also skip freeing fwspecs which are now managed by core code.

Does this depend on any other series? I didn't see iommu_fwspec_free()
called in the core code. Or I missed anything?

>
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>
> ---
> drivers/iommu/apple-dart.c | 3 ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 8 +-------
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 14 +++-----------
> drivers/iommu/arm/arm-smmu/qcom_iommu.c | 11 -----------
> drivers/iommu/exynos-iommu.c | 3 ---
> drivers/iommu/mtk_iommu.c | 5 -----
> drivers/iommu/mtk_iommu_v1.c | 5 -----
> drivers/iommu/sprd-iommu.c | 11 -----------
> drivers/iommu/virtio-iommu.c | 8 +-------
> 9 files changed, 5 insertions(+), 63 deletions(-)

Best regards,
baolu

\
 
 \ /
  Last update: 2022-06-22 03:37    [W:0.094 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site