lkml.org 
[lkml]   [2022]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state()
    Hi,

    * Saravana Kannan <saravanak@google.com> [700101 02:00]:
    > Now that fw_devlink=on by default and fw_devlink supports
    > "power-domains" property, the execution will never get to the point
    > where driver_deferred_probe_check_state() is called before the supplier
    > has probed successfully or before deferred probe timeout has expired.
    >
    > So, delete the call and replace it with -ENODEV.

    Looks like this causes omaps to not boot in Linux next. With this
    simple-pm-bus fails to probe initially as the power-domain is not
    yet available. On platform_probe() genpd_get_from_provider() returns
    -ENOENT.

    Seems like other stuff is potentially broken too, any ideas on
    how to fix this?

    Regards,

    Tony



    >
    > Signed-off-by: Saravana Kannan <saravanak@google.com>
    > ---
    > drivers/base/power/domain.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
    > index 739e52cd4aba..3e86772d5fac 100644
    > --- a/drivers/base/power/domain.c
    > +++ b/drivers/base/power/domain.c
    > @@ -2730,7 +2730,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
    > mutex_unlock(&gpd_list_lock);
    > dev_dbg(dev, "%s() failed to find PM domain: %ld\n",
    > __func__, PTR_ERR(pd));
    > - return driver_deferred_probe_check_state(base_dev);
    > + return -ENODEV;
    > }
    >
    > dev_dbg(dev, "adding to PM domain %s\n", pd->name);
    > --
    > 2.36.1.255.ge46751e96f-goog
    >

    \
     
     \ /
      Last update: 2022-06-21 09:30    [W:2.233 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site