Messages in this thread | | | From | Hao Luo <> | Date | Tue, 21 Jun 2022 00:25:55 -0700 | Subject | Re: [PATCH bpf-next v2 3/8] bpf, iter: Fix the condition on p when calling stop. |
| |
On Mon, Jun 20, 2022 at 11:48 AM Yonghong Song <yhs@fb.com> wrote: > > On 6/10/22 12:44 PM, Yosry Ahmed wrote: > > From: Hao Luo <haoluo@google.com> > > > > In bpf_seq_read, seq->op->next() could return an ERR and jump to > > the label stop. However, the existing code in stop does not handle > > the case when p (returned from next()) is an ERR. Adds the handling > > of ERR of p by converting p into an error and jumping to done. > > > > Because all the current implementations do not have a case that > > returns ERR from next(), so this patch doesn't have behavior changes > > right now. > > > > Signed-off-by: Hao Luo <haoluo@google.com> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com> > > Acked-by: Yonghong Song <yhs@fb.com>
Yonghong, do you want to get this change in now, or you want to wait for the whole patchset? This fix is straightforward and independent of other parts. Yosry and I can rebase.
| |