lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 066/106] net: bgmac: Fix an erroneous kfree() in bgmac_remove()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit d7dd6eccfbc95ac47a12396f84e7e1b361db654b ]

    'bgmac' is part of a managed resource allocated with bgmac_alloc(). It
    should not be freed explicitly.

    Remove the erroneous kfree() from the .remove() function.

    Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Link: https://lore.kernel.org/r/a026153108dd21239036a032b95c25b5cece253b.1655153616.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
    index 9513cfb5ba58..0ce28bc955a4 100644
    --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
    +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
    @@ -323,7 +323,6 @@ static void bgmac_remove(struct bcma_device *core)
    bcma_mdio_mii_unregister(bgmac->mii_bus);
    bgmac_enet_remove(bgmac);
    bcma_set_drvdata(core, NULL);
    - kfree(bgmac);
    }

    static struct bcma_driver bgmac_bcma_driver = {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-20 15:26    [W:3.252 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site