lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 07/84] dma-debug: make things less spammy under memory pressure
    Date
    From: Rob Clark <robdclark@chromium.org>

    [ Upstream commit e19f8fa6ce1ca9b8b934ba7d2e8f34c95abc6e60 ]

    Limit the error msg to avoid flooding the console. If you have a lot of
    threads hitting this at once, they could have already gotten passed the
    dma_debug_disabled() check before they get to the point of allocation
    failure, resulting in quite a lot of this error message spamming the
    log. Use pr_err_once() to limit that.

    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/dma/debug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
    index ee7da1f2462f..ae9fc1ee6d20 100644
    --- a/kernel/dma/debug.c
    +++ b/kernel/dma/debug.c
    @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry)

    rc = active_cacheline_insert(entry);
    if (rc == -ENOMEM) {
    - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
    + pr_err_once("cacheline tracking ENOMEM, dma-debug disabled\n");
    global_disable = true;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-20 15:16    [W:4.093 / U:1.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site