lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] of: also handle dma-noncoherent in of_dma_is_coherent()
On Sun, Jun 19, 2022 at 10:32:09PM +0200, Heiko Stuebner wrote:
> bool of_dma_is_coherent(struct device_node *np)
> {
> struct device_node *node;
> + bool ret = false;

I'd rename this to coherent or is_coherent.

>
> if (IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT))
> - return true;
> + ret = true;

And then do this at initialization time:

bool is_coherent = IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT);

but otherwise this looks good to me.

\
 
 \ /
  Last update: 2022-06-20 08:02    [W:0.119 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site