Messages in this thread | | | Date | Mon, 20 Jun 2022 13:21:01 +0200 | Subject | Re: [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties | From | Krzysztof Kozlowski <> |
| |
On 20/06/2022 11:34, YuTong Chang wrote: > According to technical manual(table 11-24), > the DMA of MMCHS0 should be direct mapped.
Please wrap the commit according to Linux coding style.
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
> > Signed-off-by: YuTong Chang <mtwget@gmail.com> > --- > arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi > index 7da42a5b959c..0446e2622d5f 100644 > --- a/arch/arm/boot/dts/am33xx-l4.dtsi > +++ b/arch/arm/boot/dts/am33xx-l4.dtsi > @@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET | > mmc1: mmc@0 { > compatible = "ti,am335-sdhci"; > ti,needs-special-reset; > - dmas = <&edma_xbar 24 0 0 > - &edma_xbar 25 0 0>; > + dmas = <&edma 24 0 > + &edma 25 0>;
This is still wrong from syntax point of view - should be two phandles, so <edma ...>, <edma ...>
> dma-names = "tx", "rx"; > interrupts = <64>; > reg = <0x0 0x1000>;
Best regards, Krzysztof
| |