Messages in this thread | | | Date | Mon, 20 Jun 2022 12:42:17 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc |
| |
On Mon, Jun 20, 2022 at 10:51:33AM +0200, Hans de Goede wrote: > Hi, > > Thank you for this series, cleaning this up is long overdue. > > The entire series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > for the series.
Thanks!
> Maybe do a follow up renaming CONFIG_INTEL_SOC_PMIC to > CONFIG_INTEL_SOC_PMIC_CRC and also change the module name > from intel-soc-pmic to intel-soc-pmic-crc ?
I thought about that, but decided to leave it for later since it will take a lot of subsystems and better to be considered out of the scope of this series.
Do you agree?
> I don't expect any userspace dependencies on the module-name > (there are no module parameters) so this should be fine.
-- With Best Regards, Andy Shevchenko
| |