Messages in this thread | | | Subject | Re: [PATCH] media: ov7251: add missing clk_disable_unprepare() on error in ov7251_set_power_on() | From | Yang Yingliang <> | Date | Mon, 20 Jun 2022 16:48:46 +0800 |
| |
Hi,
On 2022/6/17 18:20, Andy Shevchenko wrote: > On Fri, Jun 17, 2022 at 09:39:43AM +0800, Yang Yingliang wrote: >> Add the missing clk_disable_unprepare() before return >> from ov7251_set_power_on() in the error handling case. > ... > >> if (ret < 0) { >> dev_err(ov7251->dev, "error during global init\n"); >> + clk_disable_unprepare(ov7251->xclk); >> ov7251_regulators_disable(ov7251); > Logically it should go here. Please, read a code above this check. Do you mean print the error code on error path ?
Thanks, Yang > >> return ret; >> }
| |