Messages in this thread | | | Date | Mon, 20 Jun 2022 10:02:05 +0200 | From | Greg KH <> | Subject | Re: [PATCH] vme: Added NULL check for bridge |
| |
On Sun, Jun 19, 2022 at 12:36:45PM +0530, Souptick Joarder wrote: > From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com> > > Kernel test robot throws below warning -> > drivers/staging/vme_user/vme.c:662:20: warning: dereference > of NULL 'bridge' [CWE-476] [-Wanalyzer-null-dereference] > > Added a NULL check. > > Reported-by: Kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com> > --- > drivers/staging/vme_user/vme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c > index b5555683a069..ede774f2fe5a 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -659,7 +659,7 @@ ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t count, > struct vme_master_resource *image; > size_t length; > > - if (!bridge->master_read) { > + if (bridge && !bridge->master_read) {
How can bridge ever be NULL here?
thanks,
greg k-h
| |