lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 42/49] mfd: qcom-pm8008: Fix broken mask/unmask in irq chip
    Date
    Swap mask_base and unmask_base, and drop the broken_mask_unmask
    flag since we're now expecting the registers to have their usual
    behavior.

    Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
    ---
    drivers/mfd/qcom-pm8008.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
    index 18095e72714e..7bc6becfe7f4 100644
    --- a/drivers/mfd/qcom-pm8008.c
    +++ b/drivers/mfd/qcom-pm8008.c
    @@ -45,8 +45,8 @@ enum {
    #define PM8008_GPIO2_ADDR PM8008_PERIPH_3_BASE

    #define PM8008_STATUS_BASE (PM8008_PERIPH_0_BASE | INT_LATCHED_STS_OFFSET)
    -#define PM8008_MASK_BASE (PM8008_PERIPH_0_BASE | INT_EN_SET_OFFSET)
    -#define PM8008_UNMASK_BASE (PM8008_PERIPH_0_BASE | INT_EN_CLR_OFFSET)
    +#define PM8008_MASK_BASE (PM8008_PERIPH_0_BASE | INT_EN_CLR_OFFSET)
    +#define PM8008_UNMASK_BASE (PM8008_PERIPH_0_BASE | INT_EN_SET_OFFSET)
    #define PM8008_TYPE_BASE (PM8008_PERIPH_0_BASE | INT_SET_TYPE_OFFSET)
    #define PM8008_ACK_BASE (PM8008_PERIPH_0_BASE | INT_LATCHED_CLR_OFFSET)
    #define PM8008_POLARITY_HI_BASE (PM8008_PERIPH_0_BASE | INT_POL_HIGH_OFFSET)
    @@ -141,7 +141,6 @@ static struct regmap_irq_chip pm8008_irq_chip = {
    .status_base = PM8008_STATUS_BASE,
    .mask_base = PM8008_MASK_BASE,
    .unmask_base = PM8008_UNMASK_BASE,
    - .broken_mask_unmask = true,
    .ack_base = PM8008_ACK_BASE,
    .config_base = pm8008_config_regs,
    .num_config_bases = ARRAY_SIZE(pm8008_config_regs),
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-20 22:10    [W:4.236 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site