lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 00/49] regmap-irq cleanups and refactoring
Date
Hi Mark,

Here's a bunch of cleanups for regmap-irq focused on simplifying the API
and generalizing it a bit. It's broken up into three refactors, focusing
on one area at a time.

* Patches 01 and 02 are straightforward bugfixes, independent of the
rest of the series. Neither of the bugs are triggered by in-tree
drivers but they might be worth picking up early anyhow.

* Patches 03-13 clean up everything related to configuring IRQ types.

* Patches 14-45 deal with mask/unmask registers. First, make unmask
registers behave more intuitively and usefully, and get rid of the
mask_invert flag in favor of describing inverted mask registers as
unmask registers. Second, make the mask_writeonly flag more useful
and enable it for two chips where it makes sense.

* Patches 46-49 refactor sub_irq_reg() as a get_irq_reg() callback,
and use that to eliminate the not_fixed_stride flag.

The approach I used when refactoring is pretty simple: (1) introduce new
functionality in regmap-irq, (2) convert the drivers, and (3) remove any
old code. Nothing should break in the middle.

The patches can be re-ordered to some extent if that's preferable, but
it's best to add get_irq_reg() last to avoid having to think about how
it interacts with features that'll be removed anyway.

I can't test most of the devices affected by this series so a lot of the
code is only build tested. I've tested on real hardware with my AXP192
patchset[1], although it only provides limited code coverage.

qcom-pm8008 in particular deserves careful testing - it used all of the
features touched by the refactors and required the most changes. Other
drivers only required trivial changes but there are three of them worth
mentioning: wcd943x, wcd9335, and wcd938x. They have suspicious looking
IRQ type definitions and I'm pretty sure aren't working properly, but
I can't fix them myself. The refactor shouldn't affect their behavior
so how / when / if they get fixed shouldn't be much of an issue.

Oh, and I added the 'mask_writeonly' flag and volatile ranges to the
stpmic1 driver based on its datasheet[2] as a small optimization. It's
probably fine but testing would be a good idea.

[1]: https://lore.kernel.org/linux-iio/20220618214009.2178567-1-aidanmacdonald.0x0@gmailcom/
[2]: https://www.st.com/resource/en/datasheet/stpmic1.pdf

Aidan MacDonald (49):
regmap-irq: Fix a bug in regmap_irq_enable() for type_in_mask chips
regmap-irq: Fix offset/index mismatch in read_sub_irq_data()
regmap-irq: Remove an unnecessary restriction on type_in_mask
regmap-irq: Introduce config registers for irq types
mfd: qcom-pm8008: Convert irq chip to config regs
mfd: wcd934x: Convert irq chip to config regs
sound: soc: codecs: wcd9335: Convert irq chip to config regs
sound: soc: codecs: wcd938x: Remove spurious type_base from irq chip
mfd: max77650: Remove useless type_invert flag
regmap-irq: Remove virtual registers support
regmap-irq: Remove old type register support, refactor
regmap-irq: Remove unused type_reg_stride field
regmap-irq: Remove unused type_invert flag
regmap-irq: Do not use regmap_irq_update_bits() for wake regs
regmap-irq: Change the behavior of mask_writeonly
regmap-irq: Rename regmap_irq_update_bits()
regmap-irq: Add broken_mask_unmask flag
mfd: qcom-pm8008: Add broken_mask_unmask irq chip flag
mfd: stpmic1: Add broken_mask_unmask irq chip flag
regmap-irq: Fix inverted handling of unmask registers
mfd: tps65090: replace irqchip mask_invert with unmask_base
mfd: sun4i-gpadc: replace irqchip mask_invert with unmask_base
mfd: sprd-sc27xx-spi: replace irqchip mask_invert with unmask_base
mfd: rt5033: replace irqchip mask_invert with unmask_base
mfd: rohm-bd71828: replace irqchip mask_invert with unmask_base
mfd: rn5t618: replace irqchip mask_invert with unmask_base
mfd: gateworks-gsc: replace irqchip mask_invert with unmask_base
mfd: axp20x: replace irqchip mask_invert with unmask_base
mfd: atc260x: replace irqchip mask_invert with unmask_base
mfd: 88pm800: replace irqchip mask_invert with unmask_base
mfd: max14577: replace irqchip mask_invert with unmask_base
mfd: max77693: replace irqchip mask_invert with unmask_base
mfd: rohm-bd718x7: drop useless mask_invert flag on irqchip
mfd: max77843: drop useless mask_invert flag on irqchip
extcon: max77843: replace irqchip mask_invert with unmask_base
extcon: sm5502: drop useless mask_invert flag on irqchip
extcon: rt8973a: drop useless mask_invert flag on irqchip
irqchip: sl28cpld: replace irqchip mask_invert with unmask_base
gpio: sl28cpld: replace irqchip mask_invert with unmask_base
mfd: stpmic1: Fix broken mask/unmask in irq chip
mfd: stpmic1: Enable mask_writeonly flag for irq chip
mfd: qcom-pm8008: Fix broken mask/unmask in irq chip
mfd: qcom-pm8008: Enable mask_writeonly flag for irq chip
regmap-irq: Remove broken_mask_unmask flag
regmap-irq: Remove mask_invert flag
regmap-irq: Refactor checks for status bulk read support
regmap-irq: Add get_irq_reg() callback
mfd: qcom-pm8008: Use get_irq_reg() for irq chip
regmap-irq: Remove not_fixed_stride flag

drivers/base/regmap/regmap-irq.c | 457 ++++++++++++++-----------------
drivers/extcon/extcon-max77843.c | 3 +-
drivers/extcon/extcon-rt8973a.c | 1 -
drivers/extcon/extcon-sm5502.c | 2 -
drivers/gpio/gpio-sl28cpld.c | 3 +-
drivers/irqchip/irq-sl28cpld.c | 3 +-
drivers/mfd/88pm800.c | 3 +-
drivers/mfd/atc260x-core.c | 6 +-
drivers/mfd/axp20x.c | 21 +-
drivers/mfd/gateworks-gsc.c | 3 +-
drivers/mfd/max14577.c | 7 +-
drivers/mfd/max77650.c | 1 -
drivers/mfd/max77693.c | 6 +-
drivers/mfd/max77843.c | 1 -
drivers/mfd/qcom-pm8008.c | 131 ++++-----
drivers/mfd/rn5t618.c | 3 +-
drivers/mfd/rohm-bd71828.c | 6 +-
drivers/mfd/rohm-bd718x7.c | 1 -
drivers/mfd/rt5033.c | 3 +-
drivers/mfd/sprd-sc27xx-spi.c | 3 +-
drivers/mfd/stpmic1.c | 7 +-
drivers/mfd/sun4i-gpadc.c | 3 +-
drivers/mfd/tps65090.c | 3 +-
drivers/mfd/wcd934x.c | 11 +-
include/linux/regmap.h | 59 ++--
sound/soc/codecs/wcd9335.c | 10 +-
sound/soc/codecs/wcd938x.c | 1 -
27 files changed, 332 insertions(+), 426 deletions(-)

--
2.35.1

\
 
 \ /
  Last update: 2022-06-20 22:06    [W:0.256 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site