Messages in this thread | | | Date | Mon, 20 Jun 2022 11:18:08 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net] net/tls: fix tls_sk_proto_close executed repeatedly |
| |
On Mon, 20 Jun 2022 09:20:12 +0000 patchwork-bot+netdevbpf@kernel.org wrote: > On Mon, 20 Jun 2022 12:35:08 +0800 you wrote: > > After setting the sock ktls, update ctx->sk_proto to sock->sk_prot by > > tls_update(), so now ctx->sk_proto->close is tls_sk_proto_close(). When > > close the sock, tls_sk_proto_close() is called for sock->sk_prot->close > > is tls_sk_proto_close(). But ctx->sk_proto->close() will be executed later > > in tls_sk_proto_close(). Thus tls_sk_proto_close() executed repeatedly > > occurred. That will trigger the following bug. > > > > [...] > > Here is the summary with links: > - [net] net/tls: fix tls_sk_proto_close executed repeatedly > https://git.kernel.org/netdev/net/c/69135c572d1f
No, this is not the right fix. The AF_UNIX restructuring has moved the ULP check too late. I'll send a revert and the correct fix.
| |