lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 2/4] gpio: ch341: add GPIO MFD cell driver for the CH341
On Mon, Jun 20, 2022 at 12:26 PM Johan Hovold <johan@kernel.org> wrote:
> On Wed, Jun 15, 2022 at 08:37:45PM -0500, frank zago wrote:

...

> > + /* Create an URB for handling interrupt */
> > + dev->irq_urb = usb_alloc_urb(0, GFP_KERNEL);
> > + if (!dev->irq_urb)
> > + return dev_err_probe(&pdev->dev, -ENOMEM, "Cannot allocate the int URB\n");
>
> This isn't how dev_err_probe() is used.

While I agree on the below comment, what does this imply?

> And allocation failures are already logged so just return -ENOMEM here.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-06-20 18:09    [W:1.792 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site