lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC
    From
    Hi,

    On 6/20/22 12:43, Andy Shevchenko wrote:
    > Intel SoC PMIC is a generic name for all PMICs that are used
    > on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration
    > option refers to Crystal Cove PMIC, which has never been a part
    > of any Intel Broxton hardware. Drop wrong dependency from Kconfig.
    >
    > Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver,
    > which the Type-C depends on.
    >
    > Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
    > Reported-by: Hans de Goede <hdegoede@redhat.com>
    > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    Thanks, patch looks good to me:

    Reviewed-by: Hans de Goede <hdegoede@redhat.com>

    Regards,

    Hans


    > ---
    > drivers/usb/typec/tcpm/Kconfig | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
    > index 557f392fe24d..073fd2ea5e0b 100644
    > --- a/drivers/usb/typec/tcpm/Kconfig
    > +++ b/drivers/usb/typec/tcpm/Kconfig
    > @@ -56,7 +56,6 @@ config TYPEC_WCOVE
    > tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
    > depends on ACPI
    > depends on MFD_INTEL_PMC_BXT
    > - depends on INTEL_SOC_PMIC
    > depends on BXT_WC_PMIC_OPREGION
    > help
    > This driver adds support for USB Type-C on Intel Broxton platforms

    \
     
     \ /
      Last update: 2022-06-20 17:07    [W:3.041 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site