lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] sched: Drop outdated compile-optimization
Date
On 17/06/22 13:34, Brian Norris wrote:
> Looks like this exists from way back in 2011 (commit 095c0aa83e52
> ("sched: adjust scheduler cpu power for stolen time")), when there was a
> little more aggressive use of #if around these variables. The comment
> mostly serves to confuse the reader, although it may arguably apply to
> the (excessive) #ifdef CONFIG_HAVE_SCHED_AVG_IRQ.
>
> Anyway, the #ifdef is not needed, so drop both the comment and the
> "optimization." Any modern compiler will realize this block is not
> needed (for one, update_irq_load_avg() is an empty function when
> !CONFIG_HAVE_SCHED_AVG_IRQ).
>
> Confirmed on:
>
> x86 gcc 11.2.0 (Debian)
> x86 clang 13.0.1 (Debian)
> aarch64-linux-gnu-gcc 11.2.0 (Debian)
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>

\
 
 \ /
  Last update: 2022-06-20 16:39    [W:0.171 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site