lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 038/240] random: remove unused irq_flags argument from add_interrupt_randomness()
    Date
    From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

    commit 703f7066f40599c290babdb79dd61319264987e9 upstream.

    Since commit
    ee3e00e9e7101 ("random: use registers from interrupted code for CPU's w/o a cycle counter")

    the irq_flags argument is no longer used.

    Remove unused irq_flags.

    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Dexuan Cui <decui@microsoft.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Haiyang Zhang <haiyangz@microsoft.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: K. Y. Srinivasan <kys@microsoft.com>
    Cc: Stephen Hemminger <sthemmin@microsoft.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Wei Liu <wei.liu@kernel.org>
    Cc: linux-hyperv@vger.kernel.org
    Cc: x86@kernel.org
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Acked-by: Wei Liu <wei.liu@kernel.org>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kernel/cpu/mshyperv.c | 2 +-
    drivers/char/random.c | 4 ++--
    drivers/hv/vmbus_drv.c | 2 +-
    include/linux/random.h | 2 +-
    kernel/irq/handle.c | 2 +-
    5 files changed, 6 insertions(+), 6 deletions(-)

    --- a/arch/x86/kernel/cpu/mshyperv.c
    +++ b/arch/x86/kernel/cpu/mshyperv.c
    @@ -82,7 +82,7 @@ __visible void __irq_entry hv_stimer0_ve
    inc_irq_stat(hyperv_stimer0_count);
    if (hv_stimer0_handler)
    hv_stimer0_handler();
    - add_interrupt_randomness(HYPERV_STIMER0_VECTOR, 0);
    + add_interrupt_randomness(HYPERV_STIMER0_VECTOR);
    ack_APIC_irq();

    exiting_irq();
    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -200,7 +200,7 @@
    * void add_device_randomness(const void *buf, unsigned int size);
    * void add_input_randomness(unsigned int type, unsigned int code,
    * unsigned int value);
    - * void add_interrupt_randomness(int irq, int irq_flags);
    + * void add_interrupt_randomness(int irq);
    * void add_disk_randomness(struct gendisk *disk);
    * void add_hwgenerator_randomness(const char *buffer, size_t count,
    * size_t entropy);
    @@ -1273,7 +1273,7 @@ static __u32 get_reg(struct fast_pool *f
    return *ptr;
    }

    -void add_interrupt_randomness(int irq, int irq_flags)
    +void add_interrupt_randomness(int irq)
    {
    struct entropy_store *r;
    struct fast_pool *fast_pool = this_cpu_ptr(&irq_randomness);
    --- a/drivers/hv/vmbus_drv.c
    +++ b/drivers/hv/vmbus_drv.c
    @@ -1303,7 +1303,7 @@ static void vmbus_isr(void)
    tasklet_schedule(&hv_cpu->msg_dpc);
    }

    - add_interrupt_randomness(HYPERVISOR_CALLBACK_VECTOR, 0);
    + add_interrupt_randomness(HYPERVISOR_CALLBACK_VECTOR);
    }

    /*
    --- a/include/linux/random.h
    +++ b/include/linux/random.h
    @@ -35,7 +35,7 @@ static inline void add_latent_entropy(vo

    extern void add_input_randomness(unsigned int type, unsigned int code,
    unsigned int value) __latent_entropy;
    -extern void add_interrupt_randomness(int irq, int irq_flags) __latent_entropy;
    +extern void add_interrupt_randomness(int irq) __latent_entropy;

    extern void get_random_bytes(void *buf, int nbytes);
    extern int wait_for_random_bytes(void);
    --- a/kernel/irq/handle.c
    +++ b/kernel/irq/handle.c
    @@ -188,7 +188,7 @@ irqreturn_t handle_irq_event_percpu(stru

    retval = __handle_irq_event_percpu(desc, &flags);

    - add_interrupt_randomness(desc->irq_data.irq, flags);
    + add_interrupt_randomness(desc->irq_data.irq);

    if (!noirqdebug)
    note_interrupt(desc, retval);

    \
     
     \ /
      Last update: 2022-06-20 16:13    [W:3.365 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site