lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 219/240] irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b ]

    of_find_node_by_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: e3825ba1af3a ("irqchip/gic-v3: Add support for partitioned PPIs")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-gic-v3.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
    index 8ce4a2925e92..77a130c03223 100644
    --- a/drivers/irqchip/irq-gic-v3.c
    +++ b/drivers/irqchip/irq-gic-v3.c
    @@ -1657,12 +1657,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
    continue;

    cpu = of_cpu_node_to_id(cpu_node);
    - if (WARN_ON(cpu < 0))
    + if (WARN_ON(cpu < 0)) {
    + of_node_put(cpu_node);
    continue;
    + }

    pr_cont("%pOF[%d] ", cpu_node, cpu);

    cpumask_set_cpu(cpu, &part->mask);
    + of_node_put(cpu_node);
    }

    pr_cont("}\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-20 16:07    [W:4.042 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site