lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 217/240] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit f4b98e314888cc51486421bcf6d52852452ea48b ]

    of_find_matching_node_and_match() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-gic-realview.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c
    index b4c1924f0255..38fab02ffe9d 100644
    --- a/drivers/irqchip/irq-gic-realview.c
    +++ b/drivers/irqchip/irq-gic-realview.c
    @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent)

    /* The PB11MPCore GIC needs to be configured in the syscon */
    map = syscon_node_to_regmap(np);
    + of_node_put(np);
    if (!IS_ERR(map)) {
    /* new irq mode with no DCC */
    regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-20 16:07    [W:2.477 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site