lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: pmac32-cpufreq: Fix refcount leak bug
On 18-06-22, 10:25, Liang He wrote:
> In pmac_cpufreq_init_MacRISC3(), we need to add corresponding
> of_node_put() for the three node pointers whose refcount have
> been incremented by of_find_node_by_name().
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/cpufreq/pmac32-cpufreq.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c
> index 20f64a8b0a35..4b8ee2014da6 100644
> --- a/drivers/cpufreq/pmac32-cpufreq.c
> +++ b/drivers/cpufreq/pmac32-cpufreq.c
> @@ -470,6 +470,10 @@ static int pmac_cpufreq_init_MacRISC3(struct device_node *cpunode)
> if (slew_done_gpio_np)
> slew_done_gpio = read_gpio(slew_done_gpio_np);
>
> + of_node_put(volt_gpio_np);
> + of_node_put(freq_gpio_np);
> + of_node_put(slew_done_gpio_np);
> +
> /* If we use the frequency GPIOs, calculate the min/max speeds based
> * on the bus frequencies
> */

Applied. Thanks.

--
viresh

\
 
 \ /
  Last update: 2022-06-20 06:43    [W:0.034 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site