Messages in this thread | | | From | Namhyung Kim <> | Date | Thu, 2 Jun 2022 13:09:29 -0700 | Subject | Re: [PATCH 4/5] perf record: Allow to specify max stack depth of fp callchain |
| |
On Wed, Jun 1, 2022 at 11:30 PM Ian Rogers <irogers@google.com> wrote: > > On Tue, May 31, 2022 at 11:58 PM Namhyung Kim <namhyung@kernel.org> wrote: > > > > Currently it has no interface to specify the max stack depth for perf > > record. Extend the command line parameter to accept a number after > > 'fp' to specify the depth like '--call-graph fp,32'. > > It is valid to have call-graph=fp as a modifier on an event. To > support a depth with that we couldn't use ',' as it is already the > separator between modifiers. For consistency maybe a different > separator should be used here?
But it's already there for dwarf stack dump size like '--call-graph dwarf,4096'. Maybe we can add a new config term for the event parser.
Thanks, Namhyung
| |