lkml.org 
[lkml]   [2022]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/5] perf record: Allow to specify max stack depth of fp callchain
On Wed, Jun 1, 2022 at 11:30 PM Ian Rogers <irogers@google.com> wrote:
>
> On Tue, May 31, 2022 at 11:58 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > Currently it has no interface to specify the max stack depth for perf
> > record. Extend the command line parameter to accept a number after
> > 'fp' to specify the depth like '--call-graph fp,32'.
>
> It is valid to have call-graph=fp as a modifier on an event. To
> support a depth with that we couldn't use ',' as it is already the
> separator between modifiers. For consistency maybe a different
> separator should be used here?

But it's already there for dwarf stack dump size like
'--call-graph dwarf,4096'. Maybe we can add a new config term
for the event parser.

Thanks,
Namhyung

\
 
 \ /
  Last update: 2022-06-02 22:10    [W:0.066 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site