Messages in this thread | | | Date | Thu, 2 Jun 2022 11:41:32 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v5 6/6] mm: shrinkers: add scan interface for shrinker debugfs |
| |
On Wed, 1 Jun 2022 17:56:22 -0700 Roman Gushchin <roman.gushchin@linux.dev> wrote:
> > > > > + ssize_t ret; > > > + > > > + if (copy_from_user(kbuf, buf, read_len)) > > > + return -EFAULT; > > > + kbuf[read_len] = '\0'; > > > + > > > + if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) < 2) > > > > Was it intentional to permit more than three args? > > Good catch! No, of course it wasn't intentional. > > Below is an updated version of this patch. > > ... > > + if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) != 2) > + return -EINVAL;
s/2/3/methinks?
| |