Messages in this thread | | | Date | Thu, 2 Jun 2022 19:29:44 +0200 | Subject | Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() | From | Javier Martinez Canillas <> |
| |
On 6/2/22 19:12, David Gow wrote: > On Mon, May 30, 2022 at 9:29 AM José Expósito <jose.exposito89@gmail.com> wrote:
[snip]
>> >> A .kuniconfig example is present in the cover letter. (...) > > FYI: it's also possible to run these tests under UML with the extra options: > CONFIG_VIRTIO_UML=y > CONFIG_UML_PCI_OVER_VIRTIO=y >
Oh, very interesting. I didn't notice before that his example had --arch=x86_64
> I suspect it's probably better not to add those to your .kunitconfig, > as they're UML-specific and will therefore break other architectures, > but it does mean the tests can be run with, for example: > > ./tools/testing/kunit/kunit.py run --kunitconfig > drivers/gpu/drm/.kunitconfig --kconfig_add CONFIG_VIRTIO_UML=y > --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > > Or, without the .kunitconfig: > ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_DRM=y > --kconfig_add CONFIG_DRM_FORMAR_HELPER_TEST=y --kconfig_add > CONFIG_VIRTIO_UML=y --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > 'drm-*' >
I wonder if would make sense to have for example an arch/um/.kunitconfig with those symbols and maybe others and then the tests could also be run with something like:
./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig \ --kunitconfig=arch/um/.kunitconfig
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |