lkml.org 
[lkml]   [2022]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm64: dts: Add support for Stratix 10 Software Virtual Platform
Date
From: wen.ping.teh@intel.com

Hello Robin,

>> +/ {
>> + model = "SOCFPGA Stratix 10 SWVP";
>> + compatible = "arm,foundation-aarch64", "arm,vexpress";
>
>This is definitely not compatible with any Arm Versatile Express
>platform. It doesn't even have RAM in the same place, for starters.

Will change to the correct platform i.e. "altr,socfpga-stratix10"

>> + l2-cache@fffff000 {
>> + compatible = "arm,pl310-cache";
>
>Yikes, I hope not!
>
>I didn't think AArch64 even allows outer caches that don't honour CPU
>cache maintenance by VA? Either way I can't imagine we'd ever accept
>PL310 support in mainline, so even if your model does actually have this
>for some inexplicable reason, I don't think there's any point exposing
>it in the DT.

Will remove outer cache.
All fixes have been done in v2 patch.
https://lore.kernel.org/linux-arm-kernel/20220602141151.3431212-1-wen.ping.teh@intel.com/T/#u

Thanks,
Wen Ping
\
 
 \ /
  Last update: 2022-06-02 16:41    [W:0.116 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site