Messages in this thread | | | Date | Thu, 2 Jun 2022 12:50:36 +0200 | Subject | Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed | From | Hans de Goede <> |
| |
Hi,
On 6/2/22 11:42, Yihao Han wrote: > clk_put() already checks the clk ptr using !clk and IS_ERR() > so there is no need to check it again before calling it. > > Signed-off-by: Yihao Han <hanyihao@vivo.com> > --- > drivers/video/fbdev/simplefb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c > index 2c198561c338..f96ce8801be4 100644 > --- a/drivers/video/fbdev/simplefb.c > +++ b/drivers/video/fbdev/simplefb.c > @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par, > if (IS_ERR(clock)) { > if (PTR_ERR(clock) == -EPROBE_DEFER) { > while (--i >= 0) { > - if (par->clks[i]) > - clk_put(par->clks[i]); > + clk_put(par->clks[i]); > } > kfree(par->clks); > return -EPROBE_DEFER;
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
| |