Messages in this thread Patch in this message | | | From | Miaoqian Lin <> | Subject | [PATCH v2] firmware: stratix10-svc: fix NULL vs IS_ERR() checking | Date | Thu, 2 Jun 2022 14:15:43 +0400 |
| |
The svc_create_memory_pool function does not return NULL. It returns error pointers.
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- Changes in v2: - add Fixes tag. Link: https://lore.kernel.org/r/20211211051320.2206-1-linmq006@gmail.com --- drivers/firmware/stratix10-svc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index 8177a0fae11d..132ea721c9a0 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -996,8 +996,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) return ret; genpool = svc_create_memory_pool(pdev, sh_memory); - if (!genpool) - return -ENOMEM; + if (IS_ERR(genpool)) + return PTR_ERR(genpool); /* allocate service controller and supporting channel */ controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL); -- 2.25.1
| |